Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributing guide #277

Merged
merged 5 commits into from
Mar 31, 2023
Merged

Contributing guide #277

merged 5 commits into from
Mar 31, 2023

Conversation

danthelion
Copy link
Contributor

Add dedicated, extended docs on how to get started with contributions.

@danthelion danthelion requested a review from glsdown March 31, 2023 10:31
@danthelion danthelion self-assigned this Mar 31, 2023
@danthelion danthelion temporarily deployed to Approve Integration Tests March 31, 2023 10:31 — with GitHub Actions Inactive
@danthelion danthelion temporarily deployed to Approve Integration Tests March 31, 2023 10:31 — with GitHub Actions Inactive
@danthelion danthelion temporarily deployed to Approve Integration Tests March 31, 2023 10:31 — with GitHub Actions Inactive
@danthelion danthelion temporarily deployed to Approve Integration Tests March 31, 2023 10:31 — with GitHub Actions Inactive
glsdown
glsdown approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@glsdown glsdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this - thank you! Added a couple of small suggestions below, but they are non-blocking and just suggestions, so leaving an approval for you to decide next steps on them.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@glsdown glsdown added the documentation Improvements or additions to documentation label Mar 31, 2023
@danthelion @glsdown
Update CONTRIBUTING.md
c5198ad 
Co-authored-by: Gemma Down <52132406+glsdown@users.noreply.github.com>
@danthelion danthelion temporarily deployed to Approve Integration Tests March 31, 2023 11:13 — with GitHub Actions Inactive
@danthelion danthelion temporarily deployed to Approve Integration Tests March 31, 2023 11:13 — with GitHub Actions Inactive
@danthelion danthelion temporarily deployed to Approve Integration Tests March 31, 2023 11:13 — with GitHub Actions Inactive
@danthelion danthelion temporarily deployed to Approve Integration Tests March 31, 2023 11:13 — with GitHub Actions Inactive
@danthelion @glsdown
Update CONTRIBUTING.md
3b7f95a 
Co-authored-by: Gemma Down <52132406+glsdown@users.noreply.github.com>
@danthelion danthelion temporarily deployed to Approve Integration Tests March 31, 2023 11:13 — with GitHub Actions Inactive
@danthelion danthelion temporarily deployed to Approve Integration Tests March 31, 2023 11:13 — with GitHub Actions Inactive
@danthelion danthelion temporarily deployed to Approve Integration Tests March 31, 2023 11:13 — with GitHub Actions Inactive
@danthelion danthelion temporarily deployed to Approve Integration Tests March 31, 2023 11:13 — with GitHub Actions Inactive
@danthelion @glsdown
Update CONTRIBUTING.md
79f117e 
Co-authored-by: Gemma Down <52132406+glsdown@users.noreply.github.com>
@danthelion danthelion temporarily deployed to Approve Integration Tests March 31, 2023 11:13 — with GitHub Actions Inactive
@danthelion danthelion temporarily deployed to Approve Integration Tests March 31, 2023 11:13 — with GitHub Actions Inactive
@danthelion danthelion temporarily deployed to Approve Integration Tests March 31, 2023 11:13 — with GitHub Actions Inactive
@danthelion danthelion temporarily deployed to Approve Integration Tests March 31, 2023 11:13 — with GitHub Actions Inactive
@danthelion danthelion merged commit 984e245 into main Mar 31, 2023
@danthelion danthelion deleted the contributing_guide branch March 31, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glsdown glsdown glsdown approved these changes

Assignees

@danthelion danthelion

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danthelion @glsdown