Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide source data as json blob #280

Merged
merged 20 commits into from
May 12, 2023
Merged

Provide source data as json blob #280

merged 20 commits into from
May 12, 2023

Conversation

glsdown
Copy link
Contributor

@glsdown glsdown commented Mar 31, 2023

Request in #199 to provide a column within the sources tables which includes the source data as JSON. I've added this to:

  • exposures
  • models
  • seeds
  • snapshots
  • sources
  • tests

I haven't added it to any of the _executions tables though, as the results are included in the table already, and the object that returns does not want to be serialized:

Object of type RunResult is not JSON serializable

This would resolve #199

@glsdown glsdown added the enhancement New feature or request label Mar 31, 2023
@glsdown glsdown temporarily deployed to Approve Integration Tests March 31, 2023 11:44 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests March 31, 2023 11:44 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests March 31, 2023 11:44 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests March 31, 2023 11:44 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests March 31, 2023 11:45 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests March 31, 2023 11:45 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests March 31, 2023 11:45 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests March 31, 2023 11:45 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests April 24, 2023 12:46 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests April 24, 2023 12:47 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests April 24, 2023 12:48 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests April 24, 2023 12:48 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests May 5, 2023 12:37 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests May 5, 2023 12:37 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 5, 2023 12:37 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 5, 2023 12:37 — with GitHub Actions Inactive
@glsdown glsdown force-pushed the feat/provide-source-data-as-json-blob branch from 59b7623 to 90e63dd Compare May 5, 2023 12:40
@glsdown glsdown had a problem deploying to Approve Integration Tests May 5, 2023 12:40 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests May 5, 2023 12:40 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 12:33 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 12:33 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 12:33 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 12:44 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 12:44 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 12:44 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 12:44 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 14:26 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 14:26 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 14:26 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 14:26 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 15:08 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 15:09 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 15:09 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 15:09 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 15:14 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 15:14 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 15:14 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 15:14 — with GitHub Actions Failure
@glsdown glsdown merged commit 9d510ad into main May 12, 2023
@glsdown glsdown deleted the feat/provide-source-data-as-json-blob branch May 12, 2023 15:18
@glsdown glsdown mentioned this pull request May 16, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jared-rimmer jared-rimmer jared-rimmer approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide source data as JSON blob
2 participants
@glsdown @jared-rimmer