Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for sources #282

Merged
merged 13 commits into from
May 12, 2023
Merged

Add documentation for sources #282

merged 13 commits into from
May 12, 2023

Conversation

glsdown
Copy link
Contributor

@glsdown glsdown commented Mar 31, 2023

This would resolve the issues seen in #267 which raises issues when this package is used alongside dbt_project_evaluator by adding documentation to models in the sources folder.

@glsdown glsdown added the documentation Improvements or additions to documentation label Mar 31, 2023
@glsdown glsdown temporarily deployed to Approve Integration Tests March 31, 2023 13:11 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests March 31, 2023 13:11 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests March 31, 2023 13:11 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests March 31, 2023 13:11 — with GitHub Actions Inactive
@glsdown glsdown linked an issue Mar 31, 2023 that may be closed by this pull request
docment "source" models #267
Closed
@danthelion
Copy link
Contributor

@glsdown I approved, but please check the CI run for dbx before merging!

@glsdown glsdown temporarily deployed to Approve Integration Tests April 24, 2023 09:03 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests April 24, 2023 09:03 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests April 24, 2023 09:03 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests April 24, 2023 09:03 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests April 28, 2023 09:53 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests April 28, 2023 09:53 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests April 28, 2023 09:53 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests April 28, 2023 09:53 — with GitHub Actions Error
@glsdown glsdown force-pushed the docs/add-sources-documentation branch from bb88bda to bc3930e Compare April 28, 2023 09:53
@glsdown glsdown temporarily deployed to Approve Integration Tests April 28, 2023 09:54 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests April 28, 2023 09:54 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests April 28, 2023 09:54 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests April 28, 2023 09:54 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests April 28, 2023 15:55 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests April 28, 2023 15:55 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests April 28, 2023 15:55 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests April 28, 2023 15:55 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 5, 2023 12:23 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 5, 2023 12:23 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 12:26 — with GitHub Actions Error
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 12:26 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 12:31 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 12:31 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 12:31 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 12:31 — with GitHub Actions Error
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 12:45 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 12:45 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 12:45 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 12:45 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 13:06 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 13:06 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 13:06 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 13:06 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 13:38 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 13:38 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 13:38 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 13:38 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 14:23 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 14:23 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 14:24 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 14:24 — with GitHub Actions Inactive
@glsdown glsdown merged commit 6d7625d into main May 12, 2023
@glsdown glsdown deleted the docs/add-sources-documentation branch May 12, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danthelion danthelion danthelion approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docment "source" models
2 participants
@glsdown @danthelion