Update to latest surrogate key macro #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
approved these changes
Apr 28, 2023
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Looking at issue #265 made me aware that the surrogate_key macro in use is quite out of date from the one that is currently in dbt_utils. I have therefore updated it to use the latest version (generate_surrogate_key) in the dbt_utils repo.
Update type - breaking / non-breaking
What does this solve?
Outstanding questions
I do not believe this will be a breaking change, but would be keen to get someone else's thoughts on it.
What databases have you tested with?