Bug/fix issue with single quotes in env vars #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glsdown
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
glsdown
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
glsdown
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
glsdown
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
|
I've been looking to upgrade to 2.2.2 for this feature, so a bug in it is blocking for me to upgrade. Do you have an ETA on merging and adding this to a new release? |
added 2 commits
May 12, 2023 12:46
glsdown
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Error
glsdown
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Error
glsdown
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Error
glsdown
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Error
…g/fix-issue-with-single-quotes-in-env-vars
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
glsdown
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
jared-rimmer
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When environment variables contain a single quote, the SQL produced is invalid as they were not being escaped properly. I have added additional tests into the integration test to include variables with a single quote in them.
Update type - breaking / non-breaking
What does this solve?
invocations.dbt_custom_envs#263Outstanding questions
What databases have you tested with?