Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bigquery quote issue with env vars #312

Merged
merged 4 commits into from
May 12, 2023

Conversation

glsdown
Copy link
Contributor

@glsdown glsdown commented May 12, 2023

Overview

When an environment variable has a single quote, Bigquery is unable to process it.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)

What does this solve?

None - identified in CI checks

Outstanding questions

None

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 13:48 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 13:48 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 13:48 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 13:48 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 13:52 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 13:52 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 13:52 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 13:52 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 14:16 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 14:16 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 14:16 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 14:16 — with GitHub Actions Inactive
@glsdown glsdown added the bug Something isn't working label May 12, 2023
@glsdown glsdown merged commit 633c6bb into main May 12, 2023
@glsdown glsdown deleted the fix/fix-bigquery-quote-issue-with-env-vars branch May 12, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants