Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Add max-parallel 1 to package test jobs #324

Merged
merged 1 commit into from
May 18, 2023
Merged

[Fix] Add max-parallel 1 to package test jobs #324

merged 1 commit into from
May 18, 2023

Conversation

jared-rimmer
Copy link
Member

@jared-rimmer jared-rimmer commented May 18, 2023 •
edited
Loading

Overview

  • With the current set up the test jobs run via Github Workflows are trying to write to the same tables.
  • This PR limits the max parallel jobs to 1 so that we can still benefit from the Matrix templating of tests jobs but it will ensure the jobs run one after the other.
  • Longer term plan is to remove this at a later date in favour of a more optimal set up for writing to different schemas.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)

What does this solve?

Outstanding questions

What databases have you tested with?

  • [] Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests May 18, 2023 08:45 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests May 18, 2023 08:45 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests May 18, 2023 08:45 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests May 18, 2023 08:45 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests May 18, 2023 08:45 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests May 18, 2023 08:45 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests May 18, 2023 08:45 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests May 18, 2023 08:45 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests May 18, 2023 08:45 — with GitHub Actions Failure
@jared-rimmer jared-rimmer had a problem deploying to Approve Integration Tests May 18, 2023 08:45 — with GitHub Actions Failure
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 18, 2023 08:45 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 18, 2023 08:45 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer temporarily deployed to Approve Integration Tests May 18, 2023 08:45 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer requested a review from glsdown May 18, 2023 08:45
glsdown
glsdown approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@glsdown glsdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@glsdown glsdown merged commit e7d73ce into main May 18, 2023
@glsdown glsdown deleted the fix/set-max-concurrent-jobs branch May 18, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glsdown glsdown glsdown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jared-rimmer @glsdown