-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add batching to sources and fix batch size for tests #348
Merged
jared-rimmer
merged 3 commits into
brooklyn-data:main
from
samw430:sw/improve-big-query-upload-batching
Jun 1, 2023
Merged
Add batching to sources and fix batch size for tests #348
jared-rimmer
merged 3 commits into
brooklyn-data:main
from
samw430:sw/improve-big-query-upload-batching
Jun 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samw430
had a problem deploying
to
Approve Integration Tests
May 26, 2023 17:21 — with
GitHub Actions
Failure
samw430
had a problem deploying
to
Approve Integration Tests
May 26, 2023 17:21 — with
GitHub Actions
Failure
samw430
had a problem deploying
to
Approve Integration Tests
May 26, 2023 17:21 — with
GitHub Actions
Failure
jared-rimmer
requested changes
May 30, 2023
samw430
temporarily deployed
to
Approve Integration Tests
May 30, 2023 17:42 — with
GitHub Actions
Inactive
samw430
temporarily deployed
to
Approve Integration Tests
May 30, 2023 17:42 — with
GitHub Actions
Inactive
samw430
temporarily deployed
to
Approve Integration Tests
May 30, 2023 17:42 — with
GitHub Actions
Inactive
samw430
temporarily deployed
to
Approve Integration Tests
May 31, 2023 14:49 — with
GitHub Actions
Inactive
samw430
temporarily deployed
to
Approve Integration Tests
May 31, 2023 14:49 — with
GitHub Actions
Inactive
samw430
temporarily deployed
to
Approve Integration Tests
May 31, 2023 14:49 — with
GitHub Actions
Inactive
samw430
temporarily deployed
to
Approve Integration Tests
May 31, 2023 14:49 — with
GitHub Actions
Inactive
samw430
temporarily deployed
to
Approve Integration Tests
May 31, 2023 14:49 — with
GitHub Actions
Inactive
samw430
temporarily deployed
to
Approve Integration Tests
May 31, 2023 14:49 — with
GitHub Actions
Inactive
jared-rimmer
requested changes
May 31, 2023
Co-authored-by: Jared Rimmer <100997264+jared-rimmer@users.noreply.github.com>
samw430
temporarily deployed
to
Approve Integration Tests
May 31, 2023 16:15 — with
GitHub Actions
Inactive
samw430
temporarily deployed
to
Approve Integration Tests
May 31, 2023 16:15 — with
GitHub Actions
Inactive
samw430
temporarily deployed
to
Approve Integration Tests
May 31, 2023 16:15 — with
GitHub Actions
Inactive
samw430
temporarily deployed
to
Approve Integration Tests
June 1, 2023 12:35 — with
GitHub Actions
Inactive
samw430
temporarily deployed
to
Approve Integration Tests
June 1, 2023 12:35 — with
GitHub Actions
Inactive
samw430
temporarily deployed
to
Approve Integration Tests
June 1, 2023 12:35 — with
GitHub Actions
Inactive
samw430
temporarily deployed
to
Approve Integration Tests
June 1, 2023 12:35 — with
GitHub Actions
Inactive
samw430
temporarily deployed
to
Approve Integration Tests
June 1, 2023 12:35 — with
GitHub Actions
Inactive
samw430
temporarily deployed
to
Approve Integration Tests
June 1, 2023 12:35 — with
GitHub Actions
Inactive
jared-rimmer
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update type - breaking / non-breaking
What does this solve?
15:53:26 15:53:26 Running 1 on-run-end hook 15:53:26 Uploading model executions 15:53:28 Uploading seed executions 15:53:28 Uploading snapshot executions 15:53:28 Uploading test executions 15:53:28 Uploading exposures 15:53:31 Uploading tests 15:53:46 BigQuery adapter: https://console.cloud.google.com/bigquery?project=cue-dlake-us-develop&j=bq:US:f717fe57-be4c-4184-9a34-bf3775d17d91&page=queryresults 15:53:46 Database error while running on-run-end 15:53:46 15:53:46 Finished running 11 incremental models, 23 view models in 0 hours 0 minutes and 39.34 seconds (39.34s). 15:53:46 15:53:46 Completed with 1 error and 0 warnings: 15:53:46 15:53:46 on-run-end failed, error: 15:53:46 The query is too large. The maximum standard SQL query length is 1024.00K characters, including comments and white space characters.
Outstanding questions
Anything else I should test beyond running the integration tests against BQ?
What databases have you tested with?