Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md correction #357

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

poloaraujo
Copy link
Member

@poloaraujo poloaraujo commented Jun 15, 2023

Overview

This PR makes a correction on the README.md file, in the Quickstart section.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)

What does this solve?

Removes backticks and a parenthesis from the on-run-end hook step of the Quickstart section, so the snippets can be copied directly into dbt_project.yml

image

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

README.md
- Removed backticks and one parenthesis
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests June 15, 2023 12:20 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests June 15, 2023 12:20 — with GitHub Actions Inactive
@poloaraujo poloaraujo temporarily deployed to Approve Integration Tests June 15, 2023 12:20 — with GitHub Actions Inactive
Copy link
Contributor

@glsdown glsdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this out Polo - much appreciated.

@glsdown glsdown merged commit 7cb1a07 into brooklyn-data:main Jun 15, 2023
@poloaraujo poloaraujo changed the title on-run-end hook correction README.md correction Jun 15, 2023
@poloaraujo poloaraujo had a problem deploying to Approve Integration Tests June 15, 2023 13:37 — with GitHub Actions Failure
@poloaraujo poloaraujo had a problem deploying to Approve Integration Tests June 15, 2023 13:37 — with GitHub Actions Failure
@poloaraujo poloaraujo had a problem deploying to Approve Integration Tests June 15, 2023 13:37 — with GitHub Actions Failure
@poloaraujo poloaraujo had a problem deploying to Approve Integration Tests June 15, 2023 13:37 — with GitHub Actions Failure
@poloaraujo poloaraujo had a problem deploying to Approve Integration Tests June 15, 2023 13:37 — with GitHub Actions Failure
@poloaraujo poloaraujo had a problem deploying to Approve Integration Tests June 15, 2023 13:37 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants