Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for dbt v1.6 #374

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Adding support for dbt v1.6 #374

merged 1 commit into from
Sep 11, 2023

Conversation

sfc-gh-kumaurya
Copy link
Contributor

@sfc-gh-kumaurya sfc-gh-kumaurya commented Aug 8, 2023 •
edited
Loading

Overview

Adds support to dbt version 1.6, updated workflows to run on dbt-snowflake plugin v1.6.0 and dbt version 1.6.0

Update type - non-breaking

  • Minor bug fix
  • Quality of Life improvements
  • New features (non-breaking change)

What does this solve?

Supports dbt latest version v1.6.0
issue: #373

What databases have you tested with?

  • Snowflake

@sfc-gh-kumaurya sfc-gh-kumaurya temporarily deployed to Approve Integration Tests August 8, 2023 10:45 — with GitHub Actions Inactive
@sfc-gh-kumaurya sfc-gh-kumaurya temporarily deployed to Approve Integration Tests August 8, 2023 10:45 — with GitHub Actions Inactive
@sfc-gh-kumaurya sfc-gh-kumaurya temporarily deployed to Approve Integration Tests August 8, 2023 10:45 — with GitHub Actions Inactive
@sfc-gh-kumaurya sfc-gh-kumaurya had a problem deploying to Approve Integration Tests August 8, 2023 12:27 — with GitHub Actions Failure
@sfc-gh-kumaurya sfc-gh-kumaurya had a problem deploying to Approve Integration Tests August 8, 2023 12:27 — with GitHub Actions Failure
@sfc-gh-kumaurya sfc-gh-kumaurya had a problem deploying to Approve Integration Tests August 8, 2023 12:27 — with GitHub Actions Failure
@sfc-gh-kumaurya sfc-gh-kumaurya had a problem deploying to Approve Integration Tests August 8, 2023 12:27 — with GitHub Actions Failure
@sfc-gh-kumaurya sfc-gh-kumaurya had a problem deploying to Approve Integration Tests August 8, 2023 12:27 — with GitHub Actions Failure
@sfc-gh-kumaurya sfc-gh-kumaurya had a problem deploying to Approve Integration Tests August 8, 2023 12:27 — with GitHub Actions Failure
@sfc-gh-kumaurya
Copy link
Contributor Author

@glsdown is this the right way to make a PR into dbt_artifacts and if so, could you take a look pls?

@chancekbarkley
Copy link

Is there a timeline on merging this PR?

@the-davidsn
Copy link

Push! Would be awesome having support for dbt v.1.6

@piotrs-ae
Copy link

+1 from me!

@katepaydhealth
Copy link

Looking forward to having supports for dbt v.1.6

@zhai-chris
Copy link

Yes please. Looking forward to have artifacts working for DBT 1.6.

@SarahAyaz
Copy link

Looking forward to having support for dbt v1.6

@charles-astrafy
Copy link
Contributor

+1 here as well

@RonniePitts
Copy link

PR looks good to me. @NiallRees can we merge please?

RonniePitts
RonniePitts approved these changes Aug 29, 2023
View reviewed changes
Copy link

@RonniePitts RonniePitts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version changes look fine

@NiallRees
Copy link
Contributor

PR looks good to me. @NiallRees can we merge please?

I wish I could, I’m no longer with Brooklyn Data though. I’ll reach out to someone who can and ask them to take a look.

@sfc-gh-kumaurya
Copy link
Contributor Author

PR looks good to me. @NiallRees can we merge please?

I wish I could, I’m no longer with Brooklyn Data though. I’ll reach out to someone who can and ask them to take a look.

Thank you @NiallRees, that would be very helpful.

@piotrs-ae
Copy link

Hi there, is there any possibility to get a merge soon?

@chancekbarkley
Copy link

Is this project dead?

@glsdown glsdown temporarily deployed to Approve Integration Tests September 11, 2023 11:42 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 11, 2023 11:42 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 11, 2023 11:42 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 11, 2023 11:46 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 11, 2023 11:46 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 11, 2023 11:46 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 11, 2023 11:46 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 11, 2023 11:46 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 11, 2023 11:46 — with GitHub Actions Inactive
@glsdown glsdown merged commit 8c8fbed into brooklyn-data:main Sep 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glsdown glsdown glsdown approved these changes

@RonniePitts RonniePitts RonniePitts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.