Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_test_executions_dml_sql timing #420

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Fix get_test_executions_dml_sql timing #420

merged 4 commits into from
Aug 12, 2024

Conversation

sp-tkerlavage
Copy link
Contributor

Overview

  • Implementation of get_test_executions_dml_sql has code that references model.timing. Local loop variable is test, not model. Revised code to use test instead of model.

  • Implemented snowflake_get_test_executions_dml_sql to support rows_affected.

Update type - breaking / non-breaking

  • [ * ] Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)
  • Release preparation

What does this solve?

Outstanding questions

What databases have you tested with?

  • [ * ] Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@sp-tkerlavage
* Implementation of get_test_executions_dml_sql has code that referen…
5715e73 
…ces `model.timing`. Local loop variable is `test`, not `model`. Revised code to use `test` instead of `model`.

* Implemented snowflake_get_test_executions_dml_sql to support rows_affected.
@sp-tkerlavage sp-tkerlavage had a problem deploying to Approve Integration Tests February 29, 2024 02:27 — with GitHub Actions Failure
@sp-tkerlavage sp-tkerlavage had a problem deploying to Approve Integration Tests February 29, 2024 02:27 — with GitHub Actions Failure
@sp-tkerlavage sp-tkerlavage had a problem deploying to Approve Integration Tests February 29, 2024 02:27 — with GitHub Actions Failure
@sp-tkerlavage sp-tkerlavage had a problem deploying to Approve Integration Tests February 29, 2024 02:27 — with GitHub Actions Failure
@TimWitzel TimWitzel mentioned this pull request May 2, 2024
Closed
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:00 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:05 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:05 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:05 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:05 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:05 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:05 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:05 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:05 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:05 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:06 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:06 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:06 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:06 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:06 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:06 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:06 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:06 — with GitHub Actions Inactive
@llifoawing llifoawing temporarily deployed to Approve Integration Tests August 7, 2024 23:06 — with GitHub Actions Inactive
llifoawing
llifoawing previously requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@llifoawing llifoawing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this PR and your patience waiting for a review! Just a couple minor changes needed.

macros/upload_individual_datasets/upload_test_executions.sql Outdated Show resolved Hide resolved
macros/upload_individual_datasets/upload_test_executions.sql Outdated Show resolved Hide resolved
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:42 — with GitHub Actions Inactive
@michelley-an @llifoawing
Update macros/upload_individual_datasets/upload_test_executions.sql
a0b0417 
Co-authored-by: Laura Li Foa Wing <100870296+llifoawing@users.noreply.github.com>
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests August 12, 2024 13:48 — with GitHub Actions Inactive
@michelley-an michelley-an dismissed llifoawing’s stale review August 12, 2024 13:58

committed changes

@michelley-an michelley-an merged commit 744f714 into brooklyn-data:main Aug 12, 2024
22 checks passed
@michelley-an michelley-an mentioned this pull request Aug 14, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelley-an michelley-an michelley-an approved these changes

@llifoawing llifoawing llifoawing left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sp-tkerlavage @llifoawing @michelley-an