Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sql server support #444

Merged
merged 19 commits into from
Sep 25, 2024
Merged

Add sql server support #444

merged 19 commits into from
Sep 25, 2024

Conversation

KijkEr
Copy link

@KijkEr KijkEr commented Sep 18, 2024 •
edited
Loading

Overview

Add support for SQL Server

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)
  • Release preparation

What does this solve?

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A
  • SQL Server (2022)

@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 18, 2024 09:06 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 18, 2024 09:06 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 18, 2024 09:06 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 18, 2024 09:06 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 18, 2024 09:15 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 18, 2024 09:15 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 18, 2024 09:15 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 18, 2024 09:15 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 18, 2024 12:48 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 18, 2024 12:48 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 18, 2024 12:48 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 18, 2024 12:48 — with GitHub Actions Failure
@KijkEr
Copy link
Author

KijkEr commented Sep 18, 2024

I've also added CI test support. Unsure how to test that. Any help is welcome.

@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 19, 2024 10:08 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 19, 2024 10:08 — with GitHub Actions Inactive
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 19, 2024 10:08 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 19, 2024 10:08 — with GitHub Actions Failure
@KijkEr KijkEr had a problem deploying to Approve Integration Tests September 20, 2024 05:43 — with GitHub Actions Failure
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 20, 2024 15:42 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 20, 2024 15:42 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 20, 2024 15:42 — with GitHub Actions Inactive
@KijkEr KijkEr temporarily deployed to Approve Integration Tests September 20, 2024 15:42 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:38 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:38 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:38 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:38 — with GitHub Actions Inactive
@michelley-an michelley-an merged commit d06f20f into brooklyn-data:main Sep 25, 2024
4 checks passed
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@michelley-an michelley-an temporarily deployed to Approve Integration Tests September 25, 2024 16:52 — with GitHub Actions Inactive
@KijkEr KijkEr deleted the add_sql_server_support branch September 25, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelley-an michelley-an michelley-an approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KijkEr @michelley-an @bvkabn