Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple Items in mainEntity #25

Closed
Andreas-Sommer opened this issue Nov 21, 2019 · 2 comments
Closed

Multiple Items in mainEntity #25

Andreas-Sommer opened this issue Nov 21, 2019 · 2 comments
Assignees
@brotkrueml
Labels
documentation Improvements or additions to documentation feature New feature or request

Comments

@Andreas-Sommer
Copy link

While using the API could not add multiple Question Objects in FAQPage on property mainEntity as suggested at https://developers.google.com/search/docs/data-types/faqpage
@brotkrueml brotkrueml added documentation Improvements or additions to documentation feature New feature or request labels Nov 22, 2019
@brotkrueml brotkrueml self-assigned this Nov 22, 2019
@Andreas-Sommer
Copy link
Author

Andreas-Sommer commented Nov 25, 2019 •
edited
Loading

Thanks for the feature!

[Bugfix] comparison of mainEntity as AbstractType fail in case of type array
https://github.com/belsignum/schema/commit/e203de325e467211f8f72cd57e202fdf1d6c88a6

@brotkrueml brotkrueml reopened this Nov 25, 2019
@brotkrueml
Copy link
Owner

Thanks for the hint, I will provide a bugfix release in the next days.

brotkrueml added a commit that referenced this issue Nov 26, 2019
@brotkrueml
[BUGFIX] Handle multiple items in mainEntity as array defined in WebP…
2b2358e 
…age correctly

Also: Deprecate SchemaManager->setMainEntityOfWebPage() in favour of SchemaManager->addMainEntityOfWebPage()

Related: #25
brotkrueml added a commit that referenced this issue Nov 30, 2019
@brotkrueml
[TASK] Adjust deprecation message
c73d657 
Related: #25
brotkrueml added a commit that referenced this issue Dec 1, 2019
@brotkrueml
[RELEASE] Prepare version 1.4.1
f8b9a72 
Related: #11
Related: #25
@brotkrueml brotkrueml mentioned this issue Dec 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brotkrueml brotkrueml

Labels
documentation Improvements or additions to documentation feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brotkrueml @Andreas-Sommer