-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: change EEG to EVENT_CODES #521
Conversation
Visit the preview URL for this PR (updated for commit dd190a9): https://ccv-honeycomb--pr521-ref-sep-eeg-gjdr4r95.web.app (expires Tue, 13 Aug 2024 16:03:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be sure to change the values in .env.___
too! They're all in the /env/
folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super quick change but otherwise looks great! I love the way you've broken down the issues into super small pull requests
add VITE prefix to ensure loading correctly with compiler Co-authored-by: Robert Gemma <38439940+RobertGemmaJr@users.noreply.github.com>
Rename
USE_EEG
toUSE_EVENT_CODES
to separate outUSE_EVENT_CODES
andUSE_PHOTODIODE
based on
ref-event-codes-json
branch as this is the most recent branch in a series of config folder modifications. Please let me know if I should rebase this!