Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: change EEG to EVENT_CODES #521

Merged
merged 3 commits into from
Aug 6, 2024
Merged

ref: change EEG to EVENT_CODES #521

merged 3 commits into from
Aug 6, 2024

Conversation

YUUU23
Copy link
Contributor

@YUUU23 YUUU23 commented Jul 30, 2024

Rename USE_EEG to USE_EVENT_CODES to separate out USE_EVENT_CODES and USE_PHOTODIODE

based on ref-event-codes-json branch as this is the most recent branch in a series of config folder modifications. Please let me know if I should rebase this!

@YUUU23 YUUU23 self-assigned this Jul 30, 2024
@YUUU23 YUUU23 added the 4.0 Versioning: Issue in regards to version 4.0.0 release label Jul 30, 2024
Copy link

github-actions bot commented Jul 30, 2024

Visit the preview URL for this PR (updated for commit dd190a9):

https://ccv-honeycomb--pr521-ref-sep-eeg-gjdr4r95.web.app

(expires Tue, 13 Aug 2024 16:03:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610

Copy link
Member

@RobertGemmaJr RobertGemmaJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to change the values in .env.___ too! They're all in the /env/ folder

Copy link
Member

@RobertGemmaJr RobertGemmaJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super quick change but otherwise looks great! I love the way you've broken down the issues into super small pull requests

env/.env.clinic Outdated Show resolved Hide resolved
add VITE prefix to ensure loading correctly with compiler

Co-authored-by: Robert Gemma <38439940+RobertGemmaJr@users.noreply.github.com>
Base automatically changed from ref-event-codes-json to ref-config-as-ENV August 6, 2024 16:03
@YUUU23 YUUU23 merged commit 4bf7642 into ref-config-as-ENV Aug 6, 2024
8 checks passed
@YUUU23 YUUU23 deleted the ref-sep-EEG branch August 6, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0 Versioning: Issue in regards to version 4.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seperate USE_EEG config variable into USE_EVENT_CODES and USE_PHOTODIODE
2 participants