jsPsych as global variable

[YUUU23]

• when jsPsych instance gets initialized, set global variable window.jsPsych to this object
• remove all function argument that takes in jsPsych object
• refactor all usage of jsPsych into window.jsPsych to be accessed globally
• add util function to get and return the global jsPsych instance
• tested code under different setting (clinic, home, browser, with video)

[github-actions]

Visit the preview URL for this PR (updated for commit 99556aa):

https://ccv-honeycomb--pr528-jspsych-global-0rome70j.web.app

_{(expires Wed, 21 Aug 2024 22:05:08 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 4ace1dcea913a952d2a1af84b94a4421bf36e610}

[eldu]

I see that you've created a getJsPsych utility function, but are using window.jsPsych in all of the refactored lines.

What reasoning is behind this? From my perspective it seems like you should use the utility function throughout.

[YUUU23]

I see that you've created a getJsPsych utility function, but are using window.jsPsych in all of the refactored lines.

What reasoning is behind this? From my perspective it seems like you should use the utility function throughout.

I think when I talked with Rob about this, he noted that maybe first we use the window.jsPsych method for a draft PR to ensure that everything works, and include the utilities function so that it would be more straightforward for developers with not much programming experiences to be able to access jsPsych through a utility function instead of accessing the global variable which is not as straightforward.

I do agree maybe accessing through the utility function throughout Honeycomb may be more consistent and flexible to modifications. The only thing I am unsure about is if it's necessary since accessing this object is only a oneliner.

Please let me know if you have any further thoughts on this! I'm leaning towards refactoring to access through util function throughout.

[eldu]

I see that you've created a getJsPsych utility function, but are using window.jsPsych in all of the refactored lines.
What reasoning is behind this? From my perspective it seems like you should use the utility function throughout.

I think when I talked with Rob about this, he noted that maybe first we use the window.jsPsych method for a draft PR to ensure that everything works, and include the utilities function so that it would be more straightforward for developers with not much programming experiences to be able to access jsPsych through a utility function instead of accessing the global variable which is not as straightforward.

I do agree maybe accessing through the utility function throughout Honeycomb may be more consistent and flexible to modifications. The only thing I am unsure about is if it's necessary since accessing this object is only a oneliner.

Please let me know if you have any further thoughts on this! I'm leaning towards refactoring to access through util function throughout.

Let's use the utility function that we'd be directing folks to use. It might unclear to folks if they see window.jsPsych used everywhere instead of the util function. And it would be good to test to make sure the utils function works (i believe in it fully honestly).

So take out the window.jsPsych and let's use the utility function throughout!

[eldu]

I added a comment to the other thread. Basically, let's use the utility function throughout instead of window.jsPsych !

Thanks for the great work Megan !

[YUUU23]

I see that you've created a getJsPsych utility function, but are using window.jsPsych in all of the refactored lines.
What reasoning is behind this? From my perspective it seems like you should use the utility function throughout.

I think when I talked with Rob about this, he noted that maybe first we use the window.jsPsych method for a draft PR to ensure that everything works, and include the utilities function so that it would be more straightforward for developers with not much programming experiences to be able to access jsPsych through a utility function instead of accessing the global variable which is not as straightforward.
I do agree maybe accessing through the utility function throughout Honeycomb may be more consistent and flexible to modifications. The only thing I am unsure about is if it's necessary since accessing this object is only a oneliner.
Please let me know if you have any further thoughts on this! I'm leaning towards refactoring to access through util function throughout.

Let's use the utility function that we'd be directing folks to use. It might unclear to folks if they see window.jsPsych used everywhere instead of the util function. And it would be good to test to make sure the utils function works (i believe in it fully honestly).

So take out the window.jsPsych and let's use the utility function throughout!

Just refactored this in the new commit!

[eldu]

Amazing work Megan !