Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logical expression to change back to casting to bool for prompt … #531

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

YUUU23
Copy link
Contributor

@YUUU23 YUUU23 commented Aug 14, 2024

  • Revert back a change on the logical comparison with prompts functions.
  • I think we can merge this into add-CLI-register and merge add-CLI-register (which should have all the code from this original branch) into feat-v4.
  • Since add-CLI-register doesn't have the comparison with ||, this PR actually brings in no changes to that branch.

YUUU23 and others added 3 commits August 14, 2024 01:37
Co-authored-by: Ellen Duong <shi.ellenduong@gmail.com>
Co-authored-by: Ellen Duong <shi.ellenduong@gmail.com>
@YUUU23 YUUU23 changed the base branch from feat-v4 to add-CLI-register August 14, 2024 22:12
@YUUU23 YUUU23 linked an issue Aug 15, 2024 that may be closed by this pull request
@YUUU23 YUUU23 merged commit 58fceba into add-CLI-register Aug 15, 2024
@YUUU23 YUUU23 deleted the add-commander branch August 15, 2024 01:38
@RobertGemmaJr RobertGemmaJr added the 4.0 Versioning: Issue in regards to version 4.0.0 release label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0 Versioning: Issue in regards to version 4.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add commander to CLI script
2 participants