Accessiblity #1331
Merged
Accessiblity #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavpanchekha
commented
Aug 15, 2024
| @@ -324,11 +324,13 @@ class BlockLayout: | |||
| # ... | |||
| px_size = float(node.style["font-size"][:-2]) | |||
| size = dpx(px_size * 0.75, self.zoom) | |||
| # ... | |||
There was a problem hiding this comment.
It's not the last line in the method
pavpanchekha
commented
Aug 15, 2024
| @@ -1482,10 +1486,10 @@ class LineLayout: | |||
| ``` | |||
|
|
|||
| For the [focus example](examples/example14-focus.html), the focus outline | |||
| of an `<a>` element becomes red, as in Figure 6. | |||
| of an `<a>` element becomes thicker and red, as in Figure 6. | |||
There was a problem hiding this comment.
The red isn't visible in the book, but "thicker" is and they'll hopefully trust us on "red"
pavpanchekha
commented
Aug 15, 2024
| @@ -1625,7 +1629,6 @@ class AccessibilityNode: | |||
| def __init__(self, node): | |||
| self.node = node | |||
| self.children = [] | |||
| self.text = "" | |||
There was a problem hiding this comment.
Not used until later.
pavpanchekha
commented
Aug 15, 2024
Comment on lines
-1825
to
+1831
| python3 -m pip install gtts | ||
| python3 -m pip install playsound | ||
| ``` {.sh} | ||
| python3 -m pip install gtts | ||
| python3 -m pip install playsound | ||
| ``` |
There was a problem hiding this comment.
Should not be an example style.
pavpanchekha
commented
Aug 15, 2024
Comment on lines
-2443
to
+2448
| `hit_test` function I'm calling is the same one we wrote | ||
| [earlier in Section 7.3](chrome.md#click-handling) to handle clicks, except | ||
| of course that it's searching a different tree: | ||
| `hit_test` function recurses over the accessibility tree: |
There was a problem hiding this comment.
It is not similar! An earlier draft of the book used similar code, but now the A11y hit-test method is recursive while layout hit-test isn't.
chrishtr
reviewed
Aug 15, 2024
| @@ -141,7 +141,7 @@ Zoom | |||
|
|
|||
| Let's start with the simplest accessibility problem: text on the | |||
| screen that is too small to read. It's a problem many of us will face | |||
| sooner or later, and possibly the most common user disability issue. | |||
| sooner or later, and is possibly the most common user disability issue. | |||
chrishtr
reviewed
Aug 15, 2024
| @@ -279,8 +278,10 @@ class DocumentLayout: | |||
| ``` {.python} | |||
| class Tab: | |||
| def render(self): | |||
| # ... | |||
| if self.needs_layout: | |||
chrishtr
reviewed
Aug 15, 2024
|
|
||
| def input(self, node): | ||
| # ... | ||
| # ... |
chrishtr
reviewed
Aug 15, 2024
| @@ -337,6 +340,7 @@ class InputLayout: | |||
| # ... | |||
| px_size = float(self.node.style["font-size"][:-2]) | |||
| size = dpx(px_size * 0.75, self.zoom) | |||
| # ... | |||
chrishtr
reviewed
Aug 15, 2024
| @@ -1199,7 +1204,7 @@ def paint_outline(node, cmds, rect, zoom): | |||
| cmds.append(DrawOutline(rect, "black", 1)) | |||
| ``` | |||
|
|
|||
| Set this flag in a new `focus_element` method that we'll now use | |||
| Set this `is_focused` flag in a new `focus_element` method that we'll now use | |||
chrishtr
reviewed
Aug 15, 2024
| @@ -1415,7 +1420,7 @@ Unknown pseudoclasses simply never match anything. | |||
| The focused element can now be styled. But ideally we'd also be able to | |||
| customize the focus outline itself and not just the element. That can be done | |||
| by adding support for the CSS [`outline` property][outline], which looks like | |||
| this to show a 3px red outline:[^outline-syntax] | |||
| this (for a 3-pixel-thick red outline):[^outline-syntax] | |||
chrishtr
reviewed
Aug 15, 2024
| @@ -2145,7 +2151,7 @@ The `alert` role addresses this need. A screen reader | |||
| will immediately[^alert-css] read an element with that role, no matter | |||
| where in the document the user currently is. Note that there aren't | |||
| any HTML elements whose default role is `alert`, so this requires | |||
| setting the `role` attribute. | |||
| the page author to explicitly set the `role` attribute. | |||
chrishtr
reviewed
Aug 15, 2024
| . | ||
| <br> | ||
| . | ||
| <br> . <br> . <br> . <br> . <br> . <br> . |
There was a problem hiding this comment.
Not critical IMO, but OTOH it does make the proof look a lot better...
chrishtr
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.