Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interaction of rAF with wrap #1334

Merged
merged 6 commits into from
Aug 17, 2024
Merged

Fix interaction of rAF with wrap #1334

merged 6 commits into from
Aug 17, 2024

Conversation

chrishtr
Copy link
Collaborator

wrap is not defined until later, after a discussion of the global window object. For now we can just skip that line
and get the point across. The section that defines wrap says also "We'll need to call wrap any time we use evaljs", which implies rAF also.

@chrishtr chrishtr requested a review from pavpanchekha August 15, 2024 17:33
book/embeds.md Outdated Show resolved Hide resolved
book/embeds.md Outdated Show resolved Hide resolved
Co-authored-by: Pavel Panchekha <me@pavpanchekha.com>
@chrishtr
Copy link
Collaborator Author

fixed

@pavpanchekha pavpanchekha merged commit e2f405d into main Aug 17, 2024
1 check passed
@pavpanchekha pavpanchekha deleted the fixraf branch August 17, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants