Fix examples involving script for the JS browser in chapter 9+ #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
? |
pavpanchekha
approved these changes
Sep 20, 2024
Comment on lines
18
to
+19
| console.log('Script crashed'); | ||
| console.log(e); |
There was a problem hiding this comment.
Yeah this is fine but we can probably use like console.trace or console.error, right? Not really worth optimizing I guess.
| @@ -117,7 +117,8 @@ class socket { | |||
| let [line1] = this.input.split("\r\n", 1); | |||
| let [method, path, protocol] = line1.split(" "); | |||
| this.url = this.scheme + "://" + this.host + path; | |||
| if (this.host == "localhost" && rt_constants.URLS["local://" + this.port]) { | |||
| if (this.host == "localhost" && rt_constants.URLS["local://" + this.port] && | |||
| path.indexOf("example") == -1) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several bugs:
openshould map tofilesystem.open. While that is correct, it caused code incompiler.pyto detect calls toopenand insert files on disk into the top of the JS file.renderrather than before. This is incorrect if rAF callbacks set it duringrender's callouts to JS.rt.js(only affects debugging flows).For good measure, I modified rt.js to special-case URLs with "example" in them so that they didn't cause localhost URLs to end up going to
server*.js. (Alternatively one could run the localhost server at a port other than 8000.)Now
examples/lab13-opacity-raf.htmlworks correctly in the JS cross-compiled browser.