Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buffer deprecation. #45

Closed
wants to merge 2 commits into from
Closed

Conversation

exoego
Copy link

@exoego exoego commented Sep 13, 2019

This requires to drop legacy Node.js priort to 5, since Buffer factory
methods are added in Node.js 5.10.

This requires to drop legacy Node.js priort to 5, since Buffer factory
methods are added in Node.js 5.10.
@exoego
Copy link
Author

exoego commented Sep 13, 2019

Test fails due to
https://travis-ci.org/crypto-browserify/browserify-sign/jobs/584394970#L1026-L1028

/home/travis/build/crypto-browserify/browserify-sign/node_modules/bn.js/lib/bn.js:3190
   a.umod(this.m)._forceRed(this)._move(a);
                                  ^

package.json Outdated Show resolved Hide resolved
@exoego
Copy link
Author

exoego commented Jan 21, 2020

Now test failed due to https://travis-ci.org/crypto-browserify/browserify-sign/jobs/639792703#L592

# dsa with 1024 keys
internal/crypto/sig.js:26
  this._handle.init(algorithm);
               ^
Error: Unknown message digest
    at new Sign (internal/crypto/sig.js:26:16)
    at Object.createSign (crypto.js:137:10)
    at Test.<anonymous> (/home/travis/build/crypto-browserify/browserify-sign/test/index.js:66:25)
    at Test.bound [as _cb] (/home/travis/build/crypto-browserify/browserify-sign/node_modules/tape/lib/test.js:80:32)
    at Test.run (/home/travis/build/crypto-browserify/browserify-sign/node_modules/tape/lib/test.js:96:10)
    at Test.bound [as run] (/home/travis/build/crypto-browserify/browserify-sign/node_modules/tape/lib/test.js:80:32)
    at Immediate.next (/home/travis/build/crypto-browserify/browserify-sign/node_modules/tape/lib/results.js:81:19)
    at runCallback (timers.js:705:18)
    at tryOnImmediate (timers.js:676:5)
    at processImmediate (timers.js:658:5)

@calvinmetcalf
Copy link
Contributor

v4.1.0 handles this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants