Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exposed requires being persisted across bundles #1030

Merged
1 commit merged into from
Feb 21, 2015

Conversation

latentflip
Copy link
Contributor

As mentioned in the comments on issue #908 #908 (comment), exposed files were being persisted across calls to browserify. I tracked this down to a leak where modules were being appended to the (module) global builtins object. Fixed with a test, though I'm not sure if you want a test for such a fine grained bug, so feel free to remove it, but it does demonstrate the failure & subsequent pass with this fix.

latentflip added a commit to HenrikJoreteg/moonboots that referenced this pull request Dec 17, 2014
@terinjokes
Copy link
Contributor

LGTM 👍

@substack ?

@jmm
Copy link
Collaborator

jmm commented Feb 18, 2015

I think the root cause of this might be a bug in module-deps, which I've been trying to get to the bottom of. I asked about it in browserify/module-deps/pull/65, but it was merged without comment (so far). Long story short, with the way I'm proposing resolving pathnames of exposed modules, it gets them treated as built-in (e.g. transforms aren't run). More info in /pull/1077. So I think something needs to change in module-deps re: that anyway, and it might solve the problem you're talking about as well.

@ghost
Copy link

ghost commented Feb 18, 2015

I'll have a patch fix for this soon once I finish the v9 branch.

@ghost ghost merged commit bf4ea7a into browserify:master Feb 21, 2015
@ghost
Copy link

ghost commented Feb 21, 2015

Published in 9.0.1. Thanks for the patch!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants