[Tests] add failing symlink tests

browserify · Jul 2, 2019 · 230ff85 · 230ff85
1 parent f6d8f23
commit 230ff85
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 0 deletions.
diff --git a/test/resolver/symlinked/_/node_modules/package b/test/resolver/symlinked/_/node_modules/package
diff --git a/test/resolver/symlinked/package/bar.js b/test/resolver/symlinked/package/bar.js
@@ -0,0 +1 @@
+module.exports = 'bar';
diff --git a/test/resolver/symlinked/package/package.json b/test/resolver/symlinked/package/package.json
@@ -0,0 +1,3 @@
+{
+    "main": "bar.js"
+}
diff --git a/test/symlinks.js b/test/symlinks.js
@@ -4,11 +4,13 @@ var test = require('tape');
 var resolve = require('../');
 
 var symlinkDir = path.join(__dirname, 'resolver', 'symlinked', 'symlink');
+var packageDir = path.join(__dirname, 'resolver', 'symlinked', '_', 'node_modules', 'package');
 try {
     fs.unlinkSync(symlinkDir);
 } catch (err) {}
 try {
     fs.symlinkSync('./_/symlink_target', symlinkDir, 'dir');
+    fs.symlinkSync('../../package', packageDir, 'dir');
 } catch (err) {
     if (err.code !== 'EEXIST') {
         // if fails then it is probably on Windows and lets try to create a junction
@@ -56,3 +58,21 @@ test('sync symlink when preserveSymlinks = true', function (t) {
     }, /Cannot find module 'foo'/);
     t.end();
 });
+
+test('sync symlink from node_modules to other dir when preserveSymlinks = false', function (t) {
+    var basedir = path.join(__dirname, 'resolver', 'symlinked', '_');
+    var fn = resolve.sync('package', { basedir: basedir, preserveSymlinks: false });
+
+    t.equal(fn, path.resolve(__dirname, 'resolver/symlinked/package/bar.js'));
+    t.end();
+});
+
+test('async symlink from node_modules to other dir when preserveSymlinks = false', function (t) {
+    t.plan(2);
+    var basedir = path.join(__dirname, 'resolver', 'symlinked', '_');
+    resolve('package', { basedir: basedir, preserveSymlinks: false }, function (err, result) {
+        t.notOk(err, 'no error');
+        t.equal(result, path.resolve(__dirname, 'resolver/symlinked/package/bar.js'));
+        t.end();
+    });
+});