Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .npmignore #286

Closed
wants to merge 1 commit into from
Closed

Add .npmignore #286

wants to merge 1 commit into from

Conversation

JamieMagee
Copy link

The current contents of the resolve package on npm are:

.
├── appveyor.yml
├── async.js
├── bin
├── .editorconfig
├── .eslintrc
├── example
├── .github
├── index.js
├── lib
├── LICENSE
├── package.json
├── readme.markdown
├── SECURITY.md
├── sync.js
└── test

After applying this .npmignore the contents will be:

.
├── async.js
├── bin
├── index.js
├── lib
├── LICENSE
├── package.json
├── readme.markdown
├── SECURITY.md
└── sync.js

Closes #271

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see next comment

@ljharb
Copy link
Member

ljharb commented Jul 6, 2022

First, the npmignore file in this repo is autogenerated, which is why .npmignore is gitignored. This particular change will be wiped out with every publish anyways.

Second, this is quite intentional. Those files must be included, and will forever be.

Tests should be published with every package, so that npm explore foo && npm install && npm test always works.
Duplicate of #281. Duplicate of #279. Duplicate of #239. Duplicate of #235. Duplicate of #58. Duplicate of #44. See #105 (comment).

Please do not file PRs on a project when it's unclear if the change is desired (github creates a permanent, undeletable PR ref on the repo for every PR created, so creating an unwanted PR creates pollution that can never be removed); and in this case, it should be quite clear that the change is not desired.

@ljharb ljharb closed this Jul 6, 2022
@JamieMagee JamieMagee deleted the npmignore branch July 6, 2022 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

The test/resolver/malformed_package_json/package.json leads to an fatal error when starting meteor
2 participants