Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow BinaryExpression to handle short-circuit evaluation. This is needed for many use cases involving potentially-null values.
Example:
In javascript, the
value
will be a falsey, so js does not try to evaluatevalue.length
. However, currently BinaryExpression tries to evaluate both sides of the expression before performing the operation. This leads to a crash, as length cannot be retrieved from a null value.The result is the common javascript idiom
foo && access(foo)
will not work in static-evalThe fix is to evaluate the left side first, and only evaluate the right side if the left side is not falsey.