Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WASM Bindings collapse #87
WASM Bindings collapse #87
Changes from 2 commits
fcc285e
c58072d
1b7775a
f1415fb
1d2692d
ca82346
f2bf5db
7db8d1b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saying. This change will require a change in the extension code otherwise extension code will not work out of box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't I aliased
translate
->Service::translateMultiple
in bindings? I'm hoping this is the change you're talking about.Build is failing in Extension's CircleCI (https://app.circleci.com/pipelines/github/mozilla-extensions/bergamot-browser-extension/204/workflows/ab129537-ad34-403b-b31d-40c626c19707/jobs/206/steps). But I'm guessing these are expected due to the issues discussed in mozilla-extensions/firefox-translations#83.
Can you confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well manually downloaded XPI, seems working. Edit: I take that back, didn't overwrite old extension, oops. ^_^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerinphilip We can test it with the wasm test page because that is using the latest byte based API. If it works with that then we are good to go 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no clue what is happening, but I am assuming bindings transfer is intact, given I/O works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerinphilip Let me help you with testing. I will test it at my end and confirm 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerinphilip I tested your change with the fix in #125 and it works 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have pulled #125 into a test build, still translates to "schwanger". I guess the transfer is intact from your response and this is something to resolve at my end maybe.
This file was deleted.
This file was deleted.
This file was deleted.