Skip to content
This repository has been archived by the owner on May 27, 2019. It is now read-only.

Add a button to open entry in a new tab (and use url field if it exists) #214

Closed
petr-nehez opened this issue Mar 6, 2018 · 9 comments
Closed

Comments

@petr-nehez
Copy link

General information

Would it be possible to add a feature to read url field?
I liked this in LastPass where you just search through your items, click it and the browser opens your stored URL.

  • Operating system + version: Manjaro KDE
  • Browser + version: Waterfox 56.0.4.1
  • Browserpass extension version as reported by your browser: 2.0.11
@ghost
Copy link

ghost commented Mar 6, 2018

Agreed, but foldername as URL for now may help keep it simple.

@petr-nehez
Copy link
Author

Well, I do not think foldername is the best place for URL.
I have many folders but none of them contains any URL (even not the part of it).
Then e.g. I have an item gitlab.com but the content of its url field is https://gitlab.com/users/sign_in.

@ghost
Copy link

ghost commented Mar 6, 2018 via email

@maximbaz
Copy link
Member

maximbaz commented Mar 6, 2018

Just to clarify, how do you want it to look like? Today clicking on the entry fills in the form, so is it going to be a new button next to "copy username" and "copy password"? Supporting a url field in this case is totally acceptable, with a fallback to the file name or folder name with the domain.

@petr-nehez
Copy link
Author

a new button next to "copy username" and "copy password"?

Yes, ideally 👍

@maximbaz
Copy link
Member

maximbaz commented Mar 6, 2018

This will also solve #103 by the way, at least in Chromium.

Just to make it clear, if we parse url field, it will only be used to open links with this new button, not for automatic domain matching - see #93 for more details on that.

@petr-nehez
Copy link
Author

it will only be used to open links with this new button, not for automatic domain matching

That's understandable and I even didn't think about it.

@maximbaz maximbaz changed the title Reading (and opening?) of URL field Add a button to open entry in a new tab (and use url field if it exists) Mar 6, 2018
maximbaz pushed a commit that referenced this issue Mar 21, 2018
#103)

 - Host app will now return a "url" field
 - Browser plugin has a "launch URL" button for each entry
 - Browser plugin has a new hotkey (g) to launch the URL
 - Supply basic auth credentials if necessary when launching via the extension

Note that basic auth will only work in Firefox >= 54. Older versions don't have the required API to do this.
@maximbaz
Copy link
Member

Released in v2.0.14, kudos to @erayd for implementing this!

@petr-nehez
Copy link
Author

Perfect, thanks @erayd!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants