Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect PGF/TikZ bounding boxes #2401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xworld21
Copy link
Contributor

Allow PGF and TikZ to set \pgf@relevantforpicturesizefalse, which is how pictures can override their own bounding box (see 'use as bounding box').

Fixes #2399. As usual: does it break something else?

The undesirable side effect is that figures that purposefully draw outside of the bounding box will overflow into the surrounding text. That might have been the original motivation for locking \ifpgf@relevantforpicturesize to true.

Allow PGF and TikZ to set \pgf@relevantforpicturesizefalse, which is how
pictures can override their own bounding box (see 'use as bounding
box').
@dginev
Copy link
Collaborator

dginev commented Aug 18, 2024

As usual: does it break something else?

I carried over some tikz tests that Bruce had prepared some time back, which you can use to double-check for any obvious regressions. They were added in #2314 and have a separate make target, via:

CI=true make extratest

They won't run in CI by default either, since they take a long while to complete...

@xworld21
Copy link
Contributor Author

I carried over some tikz tests that Bruce had prepared some time back, which you can use to double-check for any obvious regressions.

I only see a difference in Silviu's test 16: the square close to the no smoking sign used to have empty space to the left, now it doesn't. The no smoking sign is still in the wrong place

I also get slightly different numbers, but that's independent of this PR – possibly slight differences in TeX Live (I run 2023 final). I also don't get the <pagination role="newpage"/> element, but that's likely caused by a different change altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TikZ bounding box is not respected
2 participants