Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit test requirements of figure_mixed_content #2428

Merged

Conversation

dginev
Copy link
Collaborator

@dginev dginev commented Oct 14, 2024

Fixes #2427

This may be a change in the packaging of texlive, I am unsure. I would have assumed our texlive 2021 CI would also fail due to the various .sty dependencies not being present, but it succeeds?

To reproduce the reported error on Ubuntu (with texlive 2023), it takes:

$ sudo apt remove texlive-science

With this PR the test is gracefully skipped:

$ make test TEST_FILES=t/80_complex.t 
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/80_complex.t
t/80_complex.t .. 5/15 # Skip: Missing requirement algorithm.sty for t/complex/figure_mixed_content
t/80_complex.t .. 11/15 # Skip: Missing requirement siunitx.sty for t/complex/si
t/80_complex.t .. ok     
All tests successful.

@dginev
Copy link
Collaborator Author

dginev commented Oct 14, 2024

To be precise, the failure condition was triggered on a system where graphicx.sty was available, but algorithm.sty wasn't. Which I assume was due to it moving between texlive packages, but that's speculation.

@brucemiller
Copy link
Owner

Yeah, explicit requirements seem better than texlive versions (which don't seem very precise).

@brucemiller brucemiller merged commit 76e50b7 into brucemiller:master Oct 31, 2024
13 checks passed
@brucemiller brucemiller deleted the require-algorithm-for-mixed-figure-test branch October 31, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed test 't/complex/figure_mixed_content' (debian 12, ubuntu 24.04)
2 participants