Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notepad++ 8.3 builds change Sci_position leading to crash #218

Closed
vinsworldcom opened this issue Feb 1, 2022 · 11 comments
Closed

Notepad++ 8.3 builds change Sci_position leading to crash #218

vinsworldcom opened this issue Feb 1, 2022 · 11 comments
Milestone

Comments

@vinsworldcom
Copy link
Contributor

See here for more detail:

Basically, just take from the Notepad++ repo and replace in your repo:

  • notepad-plus-plus/scintilla/include/Scintilla.h
  • notepad-plus-plus/scintilla/include/Sci_Position.h

then recompile.

I'm currently using Python 3.0.7-alpha - Need the Python 3.8 support. I suppose the PythonScript 1.5.4 release will have this issue as well.

Cheers.

@Yaron10
Copy link

Yaron10 commented Feb 5, 2022

@vinsworldcom,

Reading your comment in Compare, I'd like to try using NPP 64-bit.
Have you built PythonScript with the new Scintilla.h and Sci_Position.h? Are those the only changes required?

Thank you.

@chcg,

Are you planing on updating to v1.5.5?

Thank you for your work.

@vinsworldcom
Copy link
Contributor Author

I did build PythonScript 3.0.7-alpha with the new headers and it seemed to fix the getRangeText() issue. Not sure if there any other >2G problems but I'm not using files that big so I really don't care.

https://community.notepad-plus-plus.org/topic/22473/pythonscript-and-system-python/10

I should note I don't really know what I'm doing other Rebuild Solution in visual studio and googling any errors that come up.

Cheers.

@Yaron10
Copy link

Yaron10 commented Feb 5, 2022

@vinsworldcom,

Thank you for the detailed reply.

I'd rather use Python 2.7 for the time being.
On switching to NPP 64-bit - should I replace anything else other than python27.dll and PythonScript.dll?

BR

@alankilborn
Copy link

On switching to NPP 64-bit - should I replace anything else other than python27.dll?

Gasp. Yes. You should do a proper install of PS 64-bit, or at least a fresh extract of all of its files from the zips.

@Yaron10
Copy link

Yaron10 commented Feb 5, 2022

@alankilborn,

I meant "On switching to NPP 64-bit - should I replace anything else other than python27.dll and PythonScript.dll?".

Anyway, thank you.

@alankilborn
Copy link

@Yaron10

Yes, I knew fully what you meant.
There are other files that are different besides the ones you mention, between 32 and 64 bit.
That's why I said you should do a proper install or extract.

@Yaron10
Copy link

Yaron10 commented Feb 5, 2022

@alankilborn,

Thanks again. I appreciate the info.

@chcg
Copy link
Collaborator

chcg commented Feb 6, 2022

First I'm changing the current master version to support 8.3 and check what needs to be changed and then investigate how it could be backported to the python 27 legacy branch.

@Yaron10
Copy link

Yaron10 commented Feb 6, 2022

@chcg,

Thank you for your ongoing work. Much appreciated.

@chcg chcg changed the title Notepad++ 8.2.2 development builds change Sci_position leading to crash Notepad++ 8.3 builds change Sci_position leading to crash Feb 17, 2022
chcg added a commit that referenced this issue Feb 17, 2022
expected to fix:
- editor.getTextRange crash notepad++ #224
- findText do not find text #223
- Notepad++ 8.3 builds change Sci_position leading to crash #218
@chcg chcg added this to the v2.0 milestone Feb 17, 2022
@chcg
Copy link
Collaborator

chcg commented Feb 17, 2022

Fixed with https://github.com/bruderstein/PythonScript/releases/tag/v2.0.0 and
https://github.com/bruderstein/PythonScript/releases/tag/v3.0.11

@chcg chcg closed this as completed Feb 17, 2022
@Yaron10
Copy link

Yaron10 commented Feb 18, 2022

@chcg,

👍
Thank you for your great work. I do appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants