Change input box get focus after run command #293
Conversation
Currently, after running a command, the focus goes to the output window with the cursor blinking in it. One needs press `Tab` twice to return to the input combobox to enter a subsequent command. It seems to be stemming from a `SetFocus()` command to the handle of `m_hInput` which is defined: PythonScript/PythonScript/src/ConsoleDialog.cpp: ``` 126: m_hInput = FindWindowEx(m_hCombo, NULL, L"Edit", NULL); ``` Though I'm not sure what that returns since I don't see an Edit box in the PythonScript dockable dialog. There is however a combobox which is set to `m_hCombo` and that is where the commands are entered. This changes the `giveInputFocus()` method in ConsoleDialog class to give focus to the combobox. The only "issue" is that when gaining focus, the text in the combobox is not cleared, it is highlighted. One can simply start typing and it will overwrite. I think a vast improvement. Fix bruderstein#184
Currently, after running a command, the focus goes to the output window with the cursor blinking in it. One needs press `Tab` twice to return to the input combobox to enter a subsequent command. It seems to be stemming from a `SetFocus()` command to the handle of `m_hInput` which is defined: PythonScript/PythonScript/src/ConsoleDialog.cpp: ``` 126: m_hInput = FindWindowEx(m_hCombo, NULL, L"Edit", NULL); ``` Though I'm not sure what that returns since I don't see an Edit box in the PythonScript dockable dialog. There is however a combobox which is set to `m_hCombo` and that is where the commands are entered. This changes the `giveInputFocus()` method in ConsoleDialog class to give focus to the combobox. The only "issue" is that when gaining focus, the text in the combobox is not cleared, it is highlighted. One can simply start typing and it will overwrite. I think a vast improvement. Fix bruderstein#184
|
Some of the existing behavior can be attributed to desires of @Yaron10 |
|
I can't remember that "desire" now. Why is v3 still Alpha? - I'm still using v2. |
I'm really surprised by that statement. :-)
Not me, unless not negatively commenting constitutes tacit approval. :-)
Not my place to comment, but since I'm replying for the above anyway... |
If I can't remember that request, I surely can't remember the relevant discussion. :)
👍 |
|
Indeed the currently blocking point to switch to python3 as stable version is: Missing features: |
|
Thank you. |
Currently, after running a command, the focus goes to the output window with the cursor blinking in it. One needs press
Tabtwice to return to the input combobox to enter a subsequent command. It seems to be stemming from aSetFocus()command to the handle ofm_hInputwhich is defined:PythonScript/PythonScript/src/ConsoleDialog.cpp:
Though I'm not sure what that returns since I don't see an Edit box in the PythonScript dockable dialog. There is however a combobox which is set to
m_hComboand that is where the commands are entered.This changes the
giveInputFocus()method in ConsoleDialog class to give focus to the combobox. The only "issue" is that when gaining focus, the text in the combobox is not cleared, it is highlighted. One can simply start typing and it will overwrite. I think a vast improvement.Fix #184