Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type issue with creation of LabelHeader #233

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

nbarraille
Copy link
Contributor

@nbarraille nbarraille commented Sep 30, 2024

Missing generic declaration in HeaderCell type creates typescript error when doing the following:

export function createDataTableHeaderCell<Item>(): HeaderLabel<Item, TablePlugins<Item>> {
    return (cell: HeaderCell<Item, TablePlugins<Item>>) =>
      createRender(MyHeaderCellComponent<Item>, {
        props: cell.props(),
      });
  }

==>

Type '(cell: HeaderCell<Item, TablePlugins<Item>>) => ComponentRenderConfig<DataTableHeaderCell<Item>>' is not assignable to type 'HeaderLabel<Item, TablePlugins<Item>>'.

@bryanmylee
Copy link
Owner

@nbarraille Thanks! I'll merge this and make a release over the weekend!

@bryanmylee bryanmylee merged commit e0fd3c7 into bryanmylee:main Oct 28, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants