Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: integrates spandrel for upscaling #464

Merged
merged 4 commits into from
Apr 18, 2024
Merged

feature: integrates spandrel for upscaling #464

merged 4 commits into from
Apr 18, 2024

Conversation

jaydrennan
Copy link
Collaborator

No description provided.

brycedrennan
brycedrennan reviewed Jan 24, 2024
View reviewed changes
imaginairy/cli/upscale.py Outdated
type=str,
help="Format file name using {original},{number},{algorithm},{date}, and {time}.",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add explanation of what syntax is and how to do zero padding and date formatting

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added zero padding and syntax explanations.

@brycedrennan
Copy link
Owner

aimg upscale tests/data/sand_upscale_difficult.jpg --upscale-model https://huggingface.co/city96/RevDiff/resolve/main/RevDiff1_x2_sharp.pth

FileNotFoundError: [Errno 2] No such file or directory: './outputs/upscaled/sand_upscale_difficult_upscaled_5762_https://huggingface.co/city96/RevDiff/resolve/main/RevDiff1_x2_sharp.pth_2024-01-23_22-37-21.jpg'

@jaydrennan
Copy link
Collaborator Author

aimg upscale tests/data/sand_upscale_difficult.jpg --upscale-model https://huggingface.co/city96/RevDiff/resolve/main/RevDiff1_x2_sharp.pth

FileNotFoundError: [Errno 2] No such file or directory: './outputs/upscaled/sand_upscale_difficult_upscaled_5762_https://huggingface.co/city96/RevDiff/resolve/main/RevDiff1_x2_sharp.pth_2024-01-23_22-37-21.jpg'

I'll change it so that urls can be submitted also.

@jaydrennan
Copy link
Collaborator Author

aimg upscale tests/data/sand_upscale_difficult.jpg --upscale-model https://huggingface.co/city96/RevDiff/resolve/main/RevDiff1_x2_sharp.pth

FileNotFoundError: [Errno 2] No such file or directory: './outputs/upscaled/sand_upscale_difficult_upscaled_5762_https://huggingface.co/city96/RevDiff/resolve/main/RevDiff1_x2_sharp.pth_2024-01-23_22-37-21.jpg'

I'll change it so that urls can be submitted also.

Changed so it pulls the file name from the url(without the extension) and assigns that as the name.

@jaydrennan jaydrennan force-pushed the update_upscaling branch 2 times, most recently from c0bcc28 to 3531968 Compare January 29, 2024 21:10
brycedrennan
brycedrennan reviewed Jan 29, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
imaginairy/api/upscale.py Outdated Show resolved Hide resolved
@brycedrennan brycedrennan mentioned this pull request Feb 20, 2024
Closed
@brycedrennan
Copy link
Owner

Whats the status of this pull request?

@brycedrennan brycedrennan merged commit 12e66a7 into master Apr 18, 2024
19 checks passed
@brycedrennan brycedrennan deleted the update_upscaling branch April 18, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brycedrennan brycedrennan brycedrennan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaydrennan @brycedrennan