Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip pycompss dependency #190

Closed
nmilosev opened this issue Apr 24, 2019 · 4 comments
Closed

pip pycompss dependency #190

nmilosev opened this issue Apr 24, 2019 · 4 comments

Comments

@nmilosev
Copy link
Contributor

Hello there,

I would like to ask if there is a specific reason why pycompss isn't listed as a hard dependency in the setup.py file?

It could be a good idea to add it, as of now if you install dislib it will not pull pycompss with itself and then it will immediately complain about a missing pycompss module which could be confusing to some users.

Just a suggestion. :)

Cheers!

@javicid
Copy link
Collaborator

javicid commented Apr 25, 2019

Hi @nmilosev!

This is a very good question, and it is something that we discussed when we created the pip package.

We chose not to list pycompss as a dependency because there are several ways in which you can install PyCOMPSs, and some of these ways do not make the pycompss module visible at installation time. For example, if PyCOMPSs is installed "manually" in certain supercomputers, the pycompss module is only visible at run time. We didn't want to get pip errors when installing dislib in these scenarios.

Were you following the quickstart guide when you had this problem? I am asking because maybe we should make this point more clear to users.

@nmilosev
Copy link
Contributor Author

Hello @javicid thank you for your quick response.

We are also using it on our cluster (I'm from UNSPMF and we are using dislib as a part of I-BiDaaS project) and everything works fine. This is just an issue I ran into when installing dislib locally for development.

I think it's a great idea to include a note of some sort in the quickstart document (which is very good already).

Thanks!

PS. Can we include our cluster on your list? :) The entry would be:

  • Axiom - University of Novi Sad, Faculty of Sciences (UNSPMF)

@javicid
Copy link
Collaborator

javicid commented Apr 25, 2019

That's great! I will add the note in the guide, and your cluster to the list! Thank you for the suggestion :)

I'm closing this issue, feel free to open new ones if you run into other errors or if you have any other suggestion.

@javicid javicid closed this as completed Apr 25, 2019
@nmilosev
Copy link
Contributor Author

Sure, thanks! :)

javicid added a commit that referenced this issue Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants