Add dynamic linking support for faster builds #26
Conversation
DSchroer
force-pushed
the
feat/dynamic-link
branch
from
1abdf54
to
7cb7c9c
Compare
| @@ -1,44 +1,29 @@ | |||
| const LIBS: [&str; 18] = [ | |||
There was a problem hiding this comment.
You can avoid having to specify the array length:
| const LIBS: [&str; 18] = [ | |
| const LIBS: &[&str] = &[ |
| println!("cargo:rustc-link-lib=static=TKBool"); | ||
| println!("cargo:rustc-link-lib=static=TKBO"); | ||
| println!("cargo:rustc-link-lib=static=TKOffset"); | ||
| let is_dynamic = std::env::var("CARGO_FEATURE_DYNAMIC").is_ok(); |
There was a problem hiding this comment.
We should be able to use the cfg macro or a cfg attribute.
if cfg!(feature = "dynamic") {
...
}or something like
#[cfg(feature = "dynamic")]
fn is_dynamic() {
true
}
#[cfg(not(feature = "dynamic"))]
fn is_dynamic() {
false
}In this case the cfg!() macro probably makes more sense.
| for lib in LIBS { | ||
| println!("cargo:rustc-link-lib=dylib={lib}"); | ||
| } | ||
| build.include("/usr/include/opencascade"); |
There was a problem hiding this comment.
Not sure this is very portable, for example if I install opencascade with homebrew on macos, it'll be in /opt/homebrew/include/opencascade.
pkg-config is pretty commonly used for this sort of task.
I have an example build.rs for another project which has a feature flag for dynamic vs. static linking, as well as usage of pkgconfig.
It'll increase the complexity of build.rs, but it makes the library more likely to build without errors when dynamically linking.
|
|
||
| println!("cargo:rustc-link-search=native={}", dst.join("lib").display()); | ||
|
|
||
| format!("{}", dst.join("include").display()) |
There was a problem hiding this comment.
Then this return value can just be
| format!("{}", dst.join("include").display()) | |
| dst.join("include") |
| @@ -63,3 +61,26 @@ fn main() { | |||
| println!("cargo:rerun-if-changed=src/lib.rs"); | |||
| println!("cargo:rerun-if-changed=include/wrapper.hxx"); | |||
| } | |||
|
|
|||
| fn build_opencascade() -> String { | |||
There was a problem hiding this comment.
This can be PathBuf instead of String (see the comment below)
| fn build_opencascade() -> String { | |
| fn build_opencascade() -> PathBuf { |
Could add thiserror as build depenancy for proper Error exit and possibly cache bundled INCLUDE/LIB like occt-sys crate
|
Closed in favor of #87 |
Working out of multiple repositories, the
opencascade-syslibrary tends to be a major bottleneck for building. Added adynamicfeature that uses system libs rather than building opencascade from scratch each time.