Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes MSVC (MSVC2019, ...) errors when projects are used which have _CRT_SECURE_NO_WARNINGS already set as part of the default build settings #72

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion BS_thread_pool_light_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*/

// Get rid of annoying MSVC warning.
#ifdef _MSC_VER
#if defined(_MSC_VER) && !defined(_CRT_SECURE_NO_WARNINGS)
#define _CRT_SECURE_NO_WARNINGS
#endif

Expand All @@ -33,6 +33,10 @@
// Include the header file for the thread pool library.
#include "BS_thread_pool_light.hpp"

// fix for MSVC/WIN32:
#undef min
#undef max

// ================
// Global variables
// ================
Expand Down
6 changes: 5 additions & 1 deletion BS_thread_pool_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*/

// Get rid of annoying MSVC warning.
#ifdef _MSC_VER
#if defined(_MSC_VER) && !defined(_CRT_SECURE_NO_WARNINGS)
#define _CRT_SECURE_NO_WARNINGS
#endif

Expand Down Expand Up @@ -38,6 +38,10 @@
// Include the header file for the thread pool library.
#include "BS_thread_pool.hpp"

// fix for MSVC/WIN32:
#undef min
#undef max

// ================
// Global variables
// ================
Expand Down