-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write_multi to use upsert_all #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skatkov
force-pushed
the
write_multi_optimizationsa
branch
from
September 19, 2023 09:27
e8a9afd
to
03aedcf
Compare
skatkov
force-pushed
the
write_multi_optimizationsa
branch
from
September 19, 2023 09:42
8d0bab0
to
26f5068
Compare
skatkov
force-pushed
the
write_multi_optimizationsa
branch
from
September 19, 2023 11:02
a31041d
to
53286ca
Compare
dim
requested changes
Sep 19, 2023
Sorry, could you pls also update changelog |
@dim do you have idea what is from with sqlite on older Rails 6 branch? |
dim
reviewed
Sep 19, 2023
skatkov
force-pushed
the
write_multi_optimizationsa
branch
from
September 19, 2023 14:42
958b97f
to
aa7db24
Compare
for proper Arel escaping
dim
reviewed
Sep 22, 2023
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #40