Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One-click not working (missing await) #91

Closed
ecm85 opened this issue Feb 28, 2020 · 1 comment
Closed

One-click not working (missing await) #91

ecm85 opened this issue Feb 28, 2020 · 1 comment

Comments

@ecm85
Copy link

ecm85 commented Feb 28, 2020

One-click is not currently working. I debugged the app and the root cause is that the async code is missing an await. InstallAsset is async void, which means it doesn't properly wait for the call to finish and the app dies before it can install. This prevents both sabers and songs from installing.

The fix is simply to change InstallAsset to async Task, and then the calls to it in App.xaml.cs need to await it, which means ArgumentHandler needs to become async too. ArgumentHandler is called from Application_Startup, which is already async, so it's a pretty trivial fix.

I can submit a PR if you'd prefer. Just let me know.

@Assistant
Copy link
Collaborator

Thanks for finding the issue, I've been hearing about it but didn't have the time to investigate. I'd appreciate a PR

Assistant added a commit that referenced this issue Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants