Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MySQL and Sqlite deps #5910

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

NicolasDorier
Copy link
Member

@NicolasDorier NicolasDorier commented Apr 8, 2024

This completely removes support for MySQL and SQLite, as well as our migration code.

  • Starting with 1.7.1 (Nov 2022), we started issuing deprecation warnings for MySQL and SQLite deployments.
  • As of 1.7.9 (Feb 2023), we began supporting migrations from MySQL and SQLite to PostgreSQL.
  • Starting with 1.9.0 (Apr 2023), using BTCPay Server with MySQL and SQLite required a special -deprecated flag.

The user base was already small, and various stacks such as Raspiblitz, Umbrel, and Embassy OS, which used MySQL, had already migrated most of their users.

By the time we release 2.0, I believe nearly two years will have elapsed since we indicated our intention to stop supporting MySQL and SQLite.

Previously, the command dotnet ef migrations add xxx used the SQLite provider to generate migration scripts, which incidentally worked for PostgreSQL as well.

This change triggered modifications to ApplicationDbContextModelSnapshot.cs, but the generated schema is nevertheless completely equivalent (this merely converted SQL standard type names to PostgreSQL-specific type names).

@NicolasDorier NicolasDorier mentioned this pull request Apr 8, 2024
1 task
@NicolasDorier NicolasDorier force-pushed the removemysql branch 3 times, most recently from 6dfd658 to 993ec21 Compare April 8, 2024 15:02
@NicolasDorier NicolasDorier merged commit f1a04a3 into btcpayserver:master Apr 15, 2024
2 of 4 checks passed
@NicolasDorier NicolasDorier deleted the removemysql branch April 15, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant