Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the configuration flow #95

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Conversation

BitcoinMitchell
Copy link
Collaborator

@BitcoinMitchell BitcoinMitchell commented Feb 14, 2024

Questions Answers
Description? - Improved the overall configuration page with extra information .
- Changed up the styling for the configuration a bit.
- Changed the module warnings to be more clear.
- Biggest changes are from a developer side, as I've split up the form.
Type? improvement
BC breaks? no
Deprecations? no
Depends on #93

Pending configuration

image

Alert

image

After setup

image

Not yet synced node

image

@BitcoinMitchell BitcoinMitchell marked this pull request as ready for review February 19, 2024 13:57
Copy link
Contributor

@ndeet ndeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed + tested on demo server.

Very nice cleanup and form UI declutter 👍

Not sure if it causes problems with PrestaShop but you could remove those docblocks by just adding the type to the class properties?

e.g.

/**
* @var PrestaShopConfiguration
*/
private $configuration;
private PrestaShopConfiguration $configuration;

@BitcoinMitchell
Copy link
Collaborator Author

Not sure if it causes problems with PrestaShop but you could remove those docblocks by just adding the type to the class properties?

It "should" be supported, as PS is now using PHP8, but I haven't changed it just yet. Will make a separate PR for it plus double check that everything has proper return types (think in some places it is missing).

@BitcoinMitchell BitcoinMitchell merged commit fc0713a into 6.x Feb 19, 2024
4 checks passed
@BitcoinMitchell BitcoinMitchell deleted the improve-configuration-page branch February 19, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants