Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: handle notfound #1603

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Conversation

tuxcanfly
Copy link
Contributor

Also, increase ban score on notfound and return whether addBanScore disconnects the peer. Backport from decred/dcrd#2253

Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment change needed but looks good.

Also could you squash this and in the commit message mention that it was backported from decred rather than only have that info in the github comment.

netsync/manager.go Outdated Show resolved Hide resolved
backport from decred/dcrd#2253

When a peer sends a notfound message, remove the hash from requested
map.  Also increase notfound ban score and return early if it
disconnects the peer.
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo jcvernaleo merged commit 24db7d7 into btcsuite:master Jul 28, 2020
@onyb onyb mentioned this pull request Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants