ci: add go 1.15 to tests

[jakesylvestre]

Note: this requires #1619 before it can be merged.

[jakesylvestre]

One more thing on this. Someone with permissions (likely @Roasbeef) will have to add this as a required test once we get this merged

[jcvernaleo]

I do not think we should be testing on three versions. The policy has always been current and current-1. So if 1.15 is current, please drop 1.13.

[jakesylvestre]

@jcvernaleo should be good to go here

[jakesylvestre]

looks like we'll need to remove 1.13 as a required check (and switch it to 1.15)

[ipriver]

JFYI
How about to also update README.md requirements version? If CI is testing only the 2 latest golang versions then there's no guarantee that the project works correctly with go version < 1.14.

[jakesylvestre]

@ipriver good call. I missed this

[jakesylvestre]

anyone know if this is still true?

[onyb]

Assuming the next release will be built with Go 1.15, we need to remove darwin-386 from release/release.sh. See why.

[onyb]

Why not 1.15?

[ipriver]

I think 1.14 is fine here as it's the minimal supported version.

https://golang.org/ref/mod#go-mod-file-go
A go directive sets the expected language version for the module.

[onyb]

Makes sense. 👍

[onyb]

@jakesyl Regarding reproducible builds, the release script is still valid for Go 1.14 / 1.15 (i.e. we still need the -trimpath build flag):

➜  btcd git:(master) ✗ go build -ldflags="-s -w -buildid=" github.com/btcsuite/btcd          
➜  btcd git:(master) ✗ go tool objdump ./btcd | grep "/Users/" | wc -l                          
    2857
➜  btcd git:(master) ✗ go build -trimpath -ldflags="-s -w -buildid=" github.com/btcsuite/btcd 
➜  btcd git:(master) ✗ go tool objdump ./btcd | grep "/Users/" | wc -l                       
       0

Apart from the -trimpath, there is no ugly workaround in the release script, we should be able to remove these lines:

However, this wasn't _fully_ solved in `go1.13`, as the build system still includes the
directory the binary is built into the binary itself. As a result, our scripts
utilize a work around needed until `go1.13.2`.

[jakesylvestre]

@onyb all set

[jakesylvestre]

ah, sorry. Need to fix release/release.sh

[jakesylvestre]

now I should be all set

[coveralls]

Pull Request Test Coverage Report for Build 258780159

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 10 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.7%) to 53.563%

---

Files with Coverage Reduction	New Missed Lines	%
database/ffldb/blockio.go	4	92.62%
peer/peer.go	6	75.87%

Totals
Change from base Build 253997810:	0.7%
Covered Lines:	20661
Relevant Lines:	38573

---

💛 - Coveralls

[jakesylvestre]

that's new

[jcvernaleo]

OK