Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetBlockVerboseTxResult should return with TxRawResult set #1654

Closed
wants to merge 7 commits into from

Conversation

darren
Copy link

@darren darren commented Oct 16, 2020

This Fixes #1653

@coveralls
Copy link

coveralls commented Oct 16, 2020

Pull Request Test Coverage Report for Build 311892241

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 152 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 53.489%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcserver.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 11 75.71%
rpcclient/chain.go 141 3.04%
Totals Coverage Status
Change from base Build 289529546: -0.01%
Covered Lines: 20774
Relevant Lines: 38838

💛 - Coveralls

@onyb onyb added the rpc label Nov 10, 2020
@@ -91,6 +91,26 @@ type GetBlockVerboseResult struct {
NextHash string `json:"nextblockhash,omitempty"`
}

// GetBlockVerboseResultReply
type GetBlockVerboseResultReply struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As indicated in this comment, I prefer reusing the existing GetBlockVerboseResult and populate the Tx field, since it's desirable to be compatible with Bitcoin Core.

You'll need to update the type of Tx field in the original GetBlockVerboseResult like this:

Tx            []TxRawResult `json:"tx,omitempty"` 

@darren darren closed this Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client.GetBlockVerboseTx returns GetBlockVerboseTxResult with empty Tx
3 participants