-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for receiving sendaddrv2 message from a peer #1670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0x915133E981cD5D9616F191977a8896522d56Cd7C
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comment nits, but other than that should resolve the current issue w.r.t neutrino peers being able to connect to bitcoind
master, and their upcoming release as well. I still wonder why a protocol version bump wasn't used instead of introducing a new message, but hey we're already here 🤷♂️
Pull Request Test Coverage Report for Build 395832549
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥟
Will update the neutrino
project as well so the main package in isolation (when not used with lnd
which will also pull in this change) can speak with the latest bitcoind
nodes.
Fixes #1661