Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for receiving sendaddrv2 message from a peer #1670

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

yaslama
Copy link
Contributor

@yaslama yaslama commented Nov 24, 2020

Fixes #1661

Copy link

@shahriyar9839 shahriyar9839 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0x915133E981cD5D9616F191977a8896522d56Cd7C

@btcsuite btcsuite deleted a comment from shahriyar9839 Nov 30, 2020
@btcsuite btcsuite deleted a comment from shahriyar9839 Nov 30, 2020
@btcsuite btcsuite deleted a comment from shahriyar9839 Nov 30, 2020
@btcsuite btcsuite deleted a comment from shahriyar9839 Nov 30, 2020
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comment nits, but other than that should resolve the current issue w.r.t neutrino peers being able to connect to bitcoind master, and their upcoming release as well. I still wonder why a protocol version bump wasn't used instead of introducing a new message, but hey we're already here 🤷‍♂️

wire/msgsendaddrv2.go Outdated Show resolved Hide resolved
wire/msgsendaddrv2.go Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 395832549

  • 0 of 17 (0.0%) changed or added relevant lines in 2 files are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.05%) to 53.369%

Changes Missing Coverage Covered Lines Changed/Added Lines %
wire/message.go 0 2 0.0%
wire/msgsendaddrv2.go 0 15 0.0%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 2 75.47%
btcec/signature.go 3 92.48%
connmgr/connmanager.go 3 86.07%
database/ffldb/blockio.go 4 92.62%
Totals Coverage Status
Change from base Build 381748156: -0.05%
Covered Lines: 20824
Relevant Lines: 39019

💛 - Coveralls

Copy link
Collaborator

@jakesylvestre jakesylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥟

Will update the neutrino project as well so the main package in isolation (when not used with lnd which will also pull in this change) can speak with the latest bitcoind nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Btcd disconnects upon receiving sendaddrv2
5 participants