Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reference the readme that we don't produce #1715

Merged
merged 1 commit into from
May 6, 2021
Merged

Don't reference the readme that we don't produce #1715

merged 1 commit into from
May 6, 2021

Conversation

jcvernaleo
Copy link
Member

Closes #1710

@jcvernaleo jcvernaleo added this to the 0.22.0 milestone Apr 18, 2021
@jcvernaleo jcvernaleo self-assigned this Apr 18, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 761544069

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 52.84%
Files with Coverage Reduction New Missed Lines %
addrmgr/addrmanager.go 1 73.25%
connmgr/connmanager.go 1 86.79%
peer/peer.go 12 75.47%
Totals Coverage Status
Change from base Build 745866572: -0.02%
Covered Lines: 20920
Relevant Lines: 39591
💛 - Coveralls

onyb
onyb approved these changes Apr 18, 2021
View reviewed changes
Copy link
Contributor

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Rjected
Rjected approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@jakesylvestre jakesylvestre merged commit 0ec4bdc into btcsuite:master May 6, 2021
@cubancorona cubancorona mentioned this pull request May 7, 2021
Closed
@jcvernaleo jcvernaleo deleted the jcv_nomsi branch May 26, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@jakesylvestre jakesylvestre jakesylvestre approved these changes

@onyb onyb onyb approved these changes

Assignees

@jcvernaleo jcvernaleo

Labels
bug documentation
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.

Remove reference to msi from README
5 participants
@jcvernaleo @coveralls @onyb @jakesylvestre @Rjected