Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to btcec/v2.1.1 and chaincfg/chainhash/v1.00 #1824

Merged
merged 1 commit into from
Mar 12, 2022
Merged

build: update to btcec/v2.1.1 and chaincfg/chainhash/v1.00 #1824

merged 1 commit into from
Mar 12, 2022

Conversation

Roasbeef
Copy link
Member

No description provided.

@Roasbeef
Copy link
Member Author

Given the change in the module files, I think we need to tag another version for the sub-modules with the more minimal go.sum files?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1960888017

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.676%
Totals Coverage Status
Change from base Build 1960508882: 0.0%
Covered Lines: 1231
Relevant Lines: 1545
💛 - Coveralls

guggero
guggero approved these changes Mar 10, 2022
View reviewed changes
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

Given the change in the module files, I think we need to tag another version for the sub-modules with the more minimal go.sum files?

Yes, I think that makes sense.

@guggero guggero mentioned this pull request Mar 10, 2022
Open
@Roasbeef Roasbeef merged commit 74e9690 into btcsuite:master Mar 12, 2022
@Roasbeef
Copy link
Member Author

Tags pushed: https://github.com/btcsuite/btcd/tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guggero guggero guggero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Roasbeef @coveralls @guggero