-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chainhash: JSON Unmarshal hash from appropriate string. #1952
chainhash: JSON Unmarshal hash from appropriate string. #1952
Conversation
Pull Request Test Coverage Report for Build 4258913166
💛 - Coveralls |
How about a simple test in Maybe something like:
|
Approved the CI run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
I see no reason for the holdup for this PR. Anything else to address? @jcvernaleo @Roasbeef |
@kcalvinalvin I have no idea why I approved but didn't merge. I must have gotten distracted or something. That delay's on me, sorry about that. Merging now. |
|
This commit(1d6e578) occurred a problem:
"error": "json: cannot unmarshal string into Go struct field OutPoint.TxIn.PreviousOutPoint.Hash of type chainhash.Hash"
adds a UnmarshalJSON() method to chainhash.Hash to fix it.