-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: Run gofmt on the entire repository #1981
Conversation
Pull Request Test Coverage Report for Build 5334742865
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Do we also need to bump the Go version of the main go.mod
so these changes aren't reverted by someone using Go 1.17?
The doc formatting changes introduced in the recent go version is increasing the diff for all of the new commits. Formatting it all in this commit will help the readability of future PRs by reducing the diff.
2df0cf9
to
ba54076
Compare
Addressed all the aforementioned formatting issues in the latest push. Also fixed some other formatting issues that I found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐲
@@ -2,6 +2,7 @@ | |||
// Use of this source code is governed by an ISC | |||
// license that can be found in the LICENSE file. | |||
|
|||
//go:build darwin || dragonfly || freebsd || linux || netbsd || openbsd || solaris |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -386,7 +387,7 @@ func (b *BlockChain) calcSequenceLock(node *blockNode, tx *btcutil.Tx, utxoView | |||
// return sequence lock values of -1 indicating that this transaction | |||
// can be included within a block at any given height or time. | |||
mTx := tx.MsgTx() | |||
sequenceLockActive := mTx.Version >= 2 && csvSoftforkActive | |||
sequenceLockActive := uint32(mTx.Version) >= 2 && csvSoftforkActive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
The doc formatting changes introduced in the recent go version is increasing the diff for all of the new commits. Formatting it all in this commit will help the readability of future PRs by reducing the diff.