Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: Run gofmt on the entire repository #1981

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

kcalvinalvin
Copy link
Collaborator

The doc formatting changes introduced in the recent go version is increasing the diff for all of the new commits. Formatting it all in this commit will help the readability of future PRs by reducing the diff.

@coveralls
Copy link

coveralls commented May 16, 2023

Pull Request Test Coverage Report for Build 5334742865

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 55.273%

Files with Coverage Reduction New Missed Lines %
peer/peer.go 3 73.49%
Totals Coverage Status
Change from base Build 5075515644: 0.0%
Covered Lines: 26667
Relevant Lines: 48246

💛 - Coveralls

Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!
Do we also need to bump the Go version of the main go.mod so these changes aren't reverted by someone using Go 1.17?

btcutil/coinset/coins.go Outdated Show resolved Hide resolved
integration/csv_fork_test.go Outdated Show resolved Hide resolved
integration/csv_fork_test.go Outdated Show resolved Hide resolved
mempool/doc.go Show resolved Hide resolved
peer/doc.go Show resolved Hide resolved
The doc formatting changes introduced in the recent go version is
increasing the diff for all of the new commits.  Formatting it all in
this commit will help the readability of future PRs by reducing the
diff.
@kcalvinalvin kcalvinalvin force-pushed the 2023-05-16-run-gofmt branch from 2df0cf9 to ba54076 Compare June 21, 2023 13:31
@kcalvinalvin
Copy link
Collaborator Author

kcalvinalvin commented Jun 21, 2023

Addressed all the aforementioned formatting issues in the latest push. Also fixed some other formatting issues that I found.

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐲

@@ -2,6 +2,7 @@
// Use of this source code is governed by an ISC
// license that can be found in the LICENSE file.

//go:build darwin || dragonfly || freebsd || linux || netbsd || openbsd || solaris
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Roasbeef Roasbeef merged commit 253b688 into btcsuite:master Jun 21, 2023
@@ -386,7 +387,7 @@ func (b *BlockChain) calcSequenceLock(node *blockNode, tx *btcutil.Tx, utxoView
// return sequence lock values of -1 indicating that this transaction
// can be included within a block at any given height or time.
mTx := tx.MsgTx()
sequenceLockActive := mTx.Version >= 2 && csvSoftforkActive
sequenceLockActive := uint32(mTx.Version) >= 2 && csvSoftforkActive
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants