Convert witnessToHex into a method ToHexStrings on TxWitness

[ffranr]

Add a method ToHexStrings to TxWitness. Remove stand alone function witnessToHex(witness wire.TxWitness) []string.

Motivation: witnessToHex is hard to access and to find.

[coveralls]

Pull Request Test Coverage Report for Build 8420439676

Details

• 0 of 14 (0.0%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.002%) to 56.879%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
rpcserver.go	0	3	0.0%
wire/msgtx.go	0	11	0.0%

Files with Coverage Reduction	New Missed Lines	%
connmgr/connmanager.go	1	86.27%

Totals
Change from base Build 8420351557:	-0.002%
Covered Lines:	29430
Relevant Lines:	51741

---

💛 - Coveralls

[halseth]

ACK

[guggero]

Thanks for the PR. I think we should just have the helper method (ToHexStrings() and perhaps a ParseWitness() function) but skip the JSON (un)marshal support (see inline comment for the reason).

[ffranr]

I've reduced the scope of this PR to just converting witnessToHex into a method ToHexStrings on TxWitness`.

[guggero]

Very nice, LGTM 🎉

Something that's also on my wish list is a simple Serialize() ([]byte, error) method for TxWitness, if you feel like adding that as well (new PR or this one, your call).

[sputn1ck]

LGTM