Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support testmempoolaccept for both bitcoind and btcd #2053

Merged
merged 11 commits into from
Jan 16, 2024
Merged

support testmempoolaccept for both bitcoind and btcd #2053

merged 11 commits into from
Jan 16, 2024

Commits on Jan 15, 2024

  1. gitignore: ignore vim files

    @yyforyongyu
    yyforyongyu committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    44abf0a View commit details
    Browse the repository at this point in the history

  2. mempool: add new method checkMempoolAcceptance 

    This commit breaks the `maybeAcceptTransaction` into two parts - the
first is reading the mempool to validate the transaction, and the
relevant logic has been moved into the new method
`checkMempoolAcceptance`. The second part is writing to the mempool, and
is kept in the method `maybeAcceptTransaction`.
    @yyforyongyu
    yyforyongyu committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    2ad8026 View commit details
    Browse the repository at this point in the history

  3. btcjson: add TestMempoolAcceptCmd

    @yyforyongyu
    yyforyongyu committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    ca4261f View commit details
    Browse the repository at this point in the history

  4. multi: add more bitcoind versions to the BackendVersion 

    This commit adds bitcoind version 22.0 and 25.0 to our `BackendVersion`
set to handle the `testmempoolaccept` RPC calls. A unit test is added to
make sure the parser works as expected.
    @yyforyongyu
    yyforyongyu committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    889cdb4 View commit details
    Browse the repository at this point in the history

  5. rpcclient: support testmempoolaccept for bitcoind

    @yyforyongyu
    yyforyongyu committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    c7e4028 View commit details
    Browse the repository at this point in the history

  6. mempool+rpcserver: add interface TxMempool 

    This commit adds a new interface `TxMempool` which defines how other
subsystems interact with `TxPool`.
    @yyforyongyu
    yyforyongyu committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    4842b23 View commit details
    Browse the repository at this point in the history

  7. btcd: add new RPC method testmempoolaccept

    @yyforyongyu
    yyforyongyu committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    6c9f7fe View commit details
    Browse the repository at this point in the history

  8. multi: map btcd mempool acceptance errors to bitcoind's `testmempoo… 

    …laccept`

This commit creates a `RejectReasonMap` to map the errors returned from
`btcd` to bitcoind's `testmempoolaccept` so the `RejectReason` is
unified at the RPC level. To make sure the map keys are unique, the
error strings are modified in `btcd`.
    @yyforyongyu
    yyforyongyu committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    ef54c49 View commit details
    Browse the repository at this point in the history

  9. rpctest: add itest for testmempoolaccept

    @yyforyongyu
    yyforyongyu committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    c104e72 View commit details
    Browse the repository at this point in the history

  10. integration: print logs to console

    @yyforyongyu
    yyforyongyu committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    8817ebd View commit details
    Browse the repository at this point in the history

  11. gomod: run go mod tidy for all modules 

    Also add the `make tidy-module` copied from `lnd`.
    @yyforyongyu
    yyforyongyu committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    fbe65bf View commit details
    Browse the repository at this point in the history