build: create btcd v0.24 release branch #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7367320359
💛 - Coveralls |
In this commit, we fix the following race condition:
```
==================
WARNING: DATA RACE
Write at 0x00c000216018 by goroutine 31:
github.com/btcsuite/btcd/rpcclient.(*Client).wsReconnectHandler()
/home/runner/work/btcd/btcd/rpcclient/infrastructure.go:736 +0x2aa
github.com/btcsuite/btcd/rpcclient.New·dwrap·13()
/home/runner/work/btcd/btcd/rpcclient/infrastructure.go:1496 +0x39
Previous read at 0x00c000216018 by goroutine 29:
github.com/btcsuite/btcd/rpcclient.(*Client).doDisconnect()
/home/runner/work/btcd/btcd/rpcclient/infrastructure.go:1079 +0x247
github.com/btcsuite/btcd/rpcclient.(*Client).Disconnect()
/home/runner/work/btcd/btcd/rpcclient/infrastructure.go:1111 +0x47
github.com/btcsuite/btcd/rpcclient.(*Client).wsInHandler()
/home/runner/work/btcd/btcd/rpcclient/infrastructure.go:491 +0x1eb
github.com/btcsuite/btcd/rpcclient.(*Client).start·dwrap·11()
/home/runner/work/btcd/btcd/rpcclient/infrastructure.go:1181 +0x39
Goroutine 31 (running) created at:
github.com/btcsuite/btcd/rpcclient.New()
/home/runner/work/btcd/btcd/rpcclient/infrastructure.go:1496 +0xd77
github.com/btcsuite/btcd/rpcclient.makeClient()
/home/runner/work/btcd/btcd/rpcclient/chain_test.go:268 +0x1f9
github.com/btcsuite/btcd/rpcclient.TestClientConnectedToWSServerRunner.func2()
/home/runner/work/btcd/btcd/rpcclient/chain_test.go:164 +0x47
testing.tRunner()
/opt/hostedtoolcache/go/1.17.5/x64/src/testing/testing.go:1259 +0x22f
testing.(*T).Run·dwrap·21()
/opt/hostedtoolcache/go/1.17.5/x64/src/testing/testing.go:1306 +0x47
Goroutine 29 (finished) created at:
github.com/btcsuite/btcd/rpcclient.(*Client).start()
/home/runner/work/btcd/btcd/rpcclient/infrastructure.go:1181 +0x2e4
github.com/btcsuite/btcd/rpcclient.New()
/home/runner/work/btcd/btcd/rpcclient/infrastructure.go:1493 +0xc51
github.com/btcsuite/btcd/rpcclient.makeClient()
/home/runner/work/btcd/btcd/rpcclient/chain_test.go:268 +0x1f9
github.com/btcsuite/btcd/rpcclient.TestClientConnectedToWSServerRunner.func2()
/home/runner/work/btcd/btcd/rpcclient/chain_test.go:164 +0x47
testing.tRunner()
/opt/hostedtoolcache/go/1.17.5/x64/src/testing/testing.go:1259 +0x22f
testing.(*T).Run·dwrap·21()
/opt/hostedtoolcache/go/1.17.5/x64/src/testing/testing.go:1306 +0x47
```
This arises as in `wsReconnectHandler`, the mutex isn't held while the
`conn` pointer is modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes to be auto generated once tagged, but the contents of the release are widespread (pruning, etc) , and in some areas transformative w.r.t IDB performance (utxo cache, countless GC optimizations, merkle tree optimizations, 3-4x speed up in IBD).